docs(acceptance): record r1/r2 gate closure and pending hardware steps
The R1 and R2 batches were recorded as gate-verified, but the Tauri release build and the Playwright suite had never been run against them. Both were executed here and pass, together with the rest of the stage gate. Record the measured numbers rather than the previously estimated ones, and name every step that still needs a live AstrBot container. F-04 is now verified at the packaging level: the production CSP containing blob: is present in the release binary. Dev builds do not inject the CSP, so this was the only automated evidence available for it; rendering an actual attachment remains a manual step. Also record two things this run surfaced. Prettier reports 25 files repo-wide, not the 20 previously written down, and the Playwright 680px case passes only because that viewport sits exactly on the second CSS breakpoint, leaving the 681px to 900px icon-only band untested and without accessible nav labels. The latter is tracked as F-62. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
这个提交存在于:
父节点
25f41ff50f
当前提交
1a18a8ac85
共有 2 个文件被更改,包括 118 次插入 和 2 次删除
|
|
@ -468,8 +468,10 @@ was verified to genuinely fail against the previous decoding (it reproduced thre
|
|||
characters in place of the leading CJK character), so it is a real regression guard rather than a
|
||||
tautology.
|
||||
|
||||
Gate result: fmt, clippy (`-D warnings`), `cargo test --workspace` (73), typecheck, lint, Vitest
|
||||
(19), and the production build all pass.
|
||||
Gate result: fmt, clippy (`-D warnings`), `cargo test --workspace`, typecheck, lint, Vitest
|
||||
(19), and the production build all pass. (The Rust count recorded here was originally 73; a
|
||||
measured run on 2026-07-27 gives 76 unit tests in `astrbot-desktop` and 96 passed / 2 ignored
|
||||
across the workspace.)
|
||||
|
||||
### Follow-up work pulled into R2 after review
|
||||
|
||||
|
|
@ -501,3 +503,53 @@ commits rewritten. Future review passes must run read-only or in an isolated wor
|
|||
- Not covered by this batch, still open from P1-2's description: `commands.rs` persists the user
|
||||
message row before the send is validated (F-18, batch R3), so a failed send still leaves a row.
|
||||
- Next: batch R3 (isolation and state correctness).
|
||||
|
||||
## 2026-07-27: R1/R2 verification closure
|
||||
|
||||
Current stage: P02 dual connections, branch `feat/p02-dual-connections`.
|
||||
|
||||
The eleven R1/R2 commits had never been pushed, and two gates recorded as outstanding had never
|
||||
run. Both are now closed. The branch was pushed to `origin` as a fast-forward
|
||||
(`785f125..573f9f7`); no history was rewritten.
|
||||
|
||||
### Executed
|
||||
|
||||
Full gate green: `cargo fmt --all -- --check`, `cargo clippy --workspace --all-targets -D warnings`,
|
||||
`cargo test --workspace` (96 passed / 2 ignored; `astrbot-desktop` unit tests 76), `npm run
|
||||
typecheck`, `npm run lint`, `npm run test -- --run` (19 / 4 files), `npm run build`, plus the two
|
||||
that had never been run: `npm run test:e2e` (5/5) and `npm run tauri:build` (NSIS, release profile
|
||||
in 3m25s). Detailed results and artifact paths are in `docs/q9-local-acceptance.md`.
|
||||
|
||||
F-04 is machine-verified at the packaging level: the production CSP containing `blob:` is present
|
||||
in the release binary. Rendering an actual attachment still requires the manual step.
|
||||
|
||||
### Defects this closure exposed
|
||||
|
||||
- `DesktopPetView.tsx` was the only formatting regression from the R1/R2 batch; it passed
|
||||
`prettier --check` at the pre-push base and failed after. Fixed.
|
||||
- `.claude/settings.local.json` is untracked yet scanned by `prettier --check .`, so
|
||||
`check:frontend` failed for any developer with local Claude Code settings. Added to
|
||||
`.prettierignore`.
|
||||
- `CHANGELOG.md` was structurally corrupted by two earlier commits: the preamble had been absorbed
|
||||
into a bullet list, the released section sat above it, and there were two unreleased headings and
|
||||
a stray BOM. Repaired without changing any entry text.
|
||||
- The fix queue had five audit findings with no F-id and no batch (P2-6, P2-7, P2-8, P2-29, P3-7).
|
||||
Assigned F-70 to F-74.
|
||||
- The Playwright suite passes, but its 680px case sits exactly on the second CSS breakpoint, so the
|
||||
681px-900px icon-only band is covered by no test and has nav buttons with no accessible label.
|
||||
Recorded against F-62; not fixed here.
|
||||
|
||||
### Test status
|
||||
|
||||
Rust 96 passed / 2 ignored. Frontend 19 passed / 4 files. Playwright 5 passed. Prettier reports 25
|
||||
files repo-wide (20 pre-existing, 3 new report documents, 1 machine-local now ignored, 1 fixed);
|
||||
a repo-wide formatting sweep stays deferred.
|
||||
|
||||
### Not claimed
|
||||
|
||||
Forgejo CI is still unverified — no runner has executed the committed workflow. Real-hardware
|
||||
acceptance for F-01, F-10, F-11, F-12, F-13, and F-49 has not been performed and is listed as
|
||||
pending in `docs/q9-local-acceptance.md`. Certificate pinning, signed updates, and dual-server soak
|
||||
remain externally blocked.
|
||||
|
||||
Next: batch R3 (isolation and state correctness), F-14 through F-19.
|
||||
|
|
|
|||
|
|
@ -42,6 +42,70 @@ This checklist covers the local Q9 release line only. It does not claim Windows
|
|||
- Tauri release executable and unsigned NSIS installer: passed.
|
||||
- Full Prettier check still reports 20 pre-existing files outside this focused fix; broad formatting was intentionally not mixed into the release increment.
|
||||
|
||||
## 2026-07-27 verification update (R1 + R2 closure)
|
||||
|
||||
The R1 and R2 batches were previously recorded as gate-verified, but the Tauri release build and
|
||||
the Playwright suite had never been executed against them. Both were run here.
|
||||
|
||||
### Gate results
|
||||
|
||||
| Command | Result |
|
||||
| --- | --- |
|
||||
| `cargo fmt --all -- --check` | passed |
|
||||
| `cargo clippy --workspace --all-targets -- -D warnings` | passed, no warnings |
|
||||
| `cargo test --workspace` | 96 passed, 0 failed, 2 ignored (`astrbot-desktop` unit 76, `dual_gateway_integration` 2, `desktop-protocol` unit 9, `protocol_contract` 5, `dual_instance` 4; `windows_dialog_smoke` and `soak` ignored) |
|
||||
| `npm run typecheck` | passed |
|
||||
| `npm run lint` | passed (`--max-warnings 0`) |
|
||||
| `npm run test -- --run` | 19 passed / 4 files |
|
||||
| `npm run build` | passed |
|
||||
| `npm run test:e2e` | 5 passed / 5 |
|
||||
| `npm run tauri:build` | passed, release profile in 3m25s |
|
||||
|
||||
This settles a documented conflict: the queue recorded the Rust total as 73 and the status summary
|
||||
as 76. The measured `astrbot-desktop` unit count is 76, so 73 was stale.
|
||||
|
||||
### Release artifact
|
||||
|
||||
- `target/release/bundle/nsis/AstrBot Desktop_0.1.0-alpha.2_x64-setup.exe`, 8,867,530 bytes,
|
||||
built 2026-07-27 00:02:12 +0800.
|
||||
- F-04 packaging is machine-verified: the production CSP string
|
||||
`img-src 'self' asset: http://asset.localhost data: blob:` is present in
|
||||
`target/release/astrbot-desktop.exe`. Dev builds do not inject the CSP, so this is the only
|
||||
automated evidence available for F-04; that an attachment actually renders still needs the
|
||||
manual step below.
|
||||
|
||||
### Findings from this run
|
||||
|
||||
- `src/features/pet/DesktopPetView.tsx` was the only formatting regression introduced by the R1/R2
|
||||
commits (verified by checking the same file at the pre-push base, where it passed). Fixed.
|
||||
- `prettier --check .` reports 25 files: 20 pre-existing tracked files, 3 new report documents,
|
||||
1 untracked machine-local file (`.claude/settings.local.json`, now in `.prettierignore`), and the
|
||||
pet view regression above. The earlier record of "20" undercounted. A repo-wide formatting sweep
|
||||
remains deliberately deferred.
|
||||
- The Playwright suite passes, but the 680px case passes for a reason worth recording: `styles.css`
|
||||
has two breakpoints. `max-width: 900px` collapses the sidebar to icons and hides the nav label,
|
||||
and `max-width: 680px` restores it as a mobile top bar. The test viewport sits exactly on the
|
||||
second breakpoint, so the accessible name is intact. The **681px–900px band is icon-only and
|
||||
covered by no test**, and in that band the nav buttons have no accessible label at all. That is
|
||||
the substance of audit P3-11 / F-62 and is not fixed here.
|
||||
|
||||
### Pending, requires a live AstrBot container
|
||||
|
||||
Not executed, not claimed. Each item names the fix it is the acceptance evidence for.
|
||||
|
||||
1. Install the fresh NSIS package, send a message with an image, confirm it renders — F-04.
|
||||
2. Pet event linkage, dragging, and the context menu — F-03.
|
||||
3. Three consecutive messages on one connection, each reply complete — F-01.
|
||||
4. Hold a connection past 30s; take one reply past 120s to completion — F-10.
|
||||
5. CJK-heavy prompts with no `U+FFFD` in the rendered reply — F-11.
|
||||
6. Disconnect and restore the network; confirm the **remote** conversation has no duplicated
|
||||
question or answer — F-12, observable only server-side.
|
||||
7. Stop generation mid-reply, restart the app, confirm nothing is still marked as generating — F-13.
|
||||
8. With a long reply in flight, confirm session lists, attachments, and capability lookups still
|
||||
respond — F-49.
|
||||
|
||||
Items 1 and 2 need only the installer, not a container.
|
||||
|
||||
## Explicitly pending external acceptance
|
||||
|
||||
- HTTPS certificate pinning requires a real HTTPS endpoint and first-trust confirmation.
|
||||
|
|
|
|||
正在加载…
添加表格
在新工单中引用