The first capture identified the real cause of a reply appearing twice,
and it was neither candidate. All 524 frames carried a message_id and
each reply used exactly one, so the event_id fallback is not involved
and neither is the history session fallback.
AstrBot interleaves two kinds of plain frame in one reply. Frames with
streaming true are incremental deltas whose total matches the complete
frame exactly. Frames with streaming false carry whole finished blocks —
one reply had five of them totalling 915 characters against 173
streamed. map_plain appends both, so the blocks show up inline during
generation, and map_complete then replaces the accumulation with the
streamed text alone, discarding them. That is the reply appearing twice
and then collapsing, and the collapse loses content.
One thing lengths cannot settle: whether a block repeats streamed text
or carries its own. One reply had 133 block characters against 142
streamed, which looks like a repeat; another had 915 against 173, which
cannot be. The two need opposite fixes, so this adds a per-stream
summary reporting how many blocks appear in the final text and in the
streamed text, as counts and lengths only.
Also records that plugin images were never sent: no media or attachment
frame appeared in any capture, and no plain frame carried a message
chain array. The attachment path has still never received data.
Refs: N-9 (new), N-4 (root cause found), N-6 (not a client defect).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Three fixes with provable root causes, and two defects left open on
purpose. The double reply bubble and the missing plugin images each have
two plausible causes in our own code, and picking one without evidence
would produce a fix that holds until a different conversation path hits
the other. Record both candidate chains, the frame trace added to settle
them, and the fact that the bubbles collapsing at the end is only the
session filter hiding an orphan that is still in state and in SQLite.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Batch R3 (F-14 through F-19) is implemented and gate-verified. Record
what changed, the measured test counts, and the two things it did not
cover: auto_connect_configured_slots is still serial, and the
operations switch guard still has no production writer.
Also record that the new tests for F-14, F-15 and F-16 were each run
against a mutation restoring the old behaviour and each fails under it,
so they are known not to be tautological.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The 2026-07-26 audit records 68 findings, but five of them never
received an F-id and belonged to no batch: P2-6 (download_attachment
buffers the whole body before checking the 16 MiB cap), P2-7 (health()
omits the bearer that SSE sends), P2-8 (the reconnect backoff resets to
100ms on a graceful close, giving a hot loop), P2-29 (JWT exp is
checked with no clock skew margin), and P3-7 (the operations switch
guard has no production writer).
Assign F-70 to F-73 into R5, which already owns gateway_client.rs and
astrbot_client.rs through F-26 and F-30, so the queue's own
same-file-same-batch rule holds and R4 and R5 do not contend for one
file. Assign F-74 into R8 with a note that R3's F-19 extends only the
guard's read side. F-69 stays permanently unassigned because it was
retracted.
Also correct the Rust test count. The queue said 67 to 73 and the
status summary said 67 to 76; a real cargo test --workspace run gives
76 unit tests in astrbot-desktop and 96 passed with 2 ignored across
the workspace, so 73 was stale.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Adds the 2026-07-26 full-source audit and the execution-ordered fix queue, and
records what actually happened when R1 and R2 were verified:
- R1 had never been compiled. The gate found a type error introduced by its own
`.nullish()` widening and a lint failure from a non-component export, plus one
acceptance test that was specified but never written.
- R2 landed F-10 through F-13, and an adversarial review of it surfaced three
defects the batch had itself introduced, all fixed in the same batch.
- The review subagents ran against the live working tree and left mutations
behind, including a deliberate duplicate POST inside the stream error path.
That injected code was briefly mistaken for a real HTTP-stack defect. It has
been removed and the process note recorded so review runs are isolated next
time.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>