AstrBot-Desktop/crates
YokiiroBW 6e81a3a7ae fix(astrbot): scope stream event ids and fix the transport layer
Combines the P0 event-id fix with the three transport fixes that rewrite the
same stream loop; they are not separable in these two files.

fix(astrbot): scope stream event ids per request (P0-1 / F-01)
  `AstrBotStreamMapper` restarts its sequence at zero for every stream, but
  `seen_event_ids` lives on the client and outlives a request. Event ids were
  built from `server_instance_id + sequence` alone, so the second message on a
  connection replayed the first message's ids and every one of its events was
  discarded as a duplicate: the assistant's reply never reached the UI or the
  database. Ids now carry a per-request `stream_id`.

fix(protocol): serialize model options in camelCase (P1-7b / F-07)
  `AstrBotModelOption` had no `rename_all`, so the frontend's `isDefault` was
  always undefined and no model was preselected.

fix(net): stop total timeouts from killing streams (P1-1 / F-10)
  `Client::timeout` runs from the start of the request until the body is
  finished and keeps counting while `bytes_stream()` is consumed. The 30s
  desktop-v1 budget therefore tore the long-lived SSE connection down every 30
  seconds no matter how healthy it was — heartbeats could not keep it alive —
  and the 120s AstrBot budget cut off any generation longer than two minutes.
  Streaming now uses a separate client with no total deadline, detecting a
  stalled peer with `read_timeout` (which resets on every successful read) plus
  a TCP keepalive. REST endpoints keep their total deadline.

fix(astrbot): decode sse bytes on line boundaries (P1-3 / F-11)
  Decoding each network chunk with `String::from_utf8_lossy` corrupted any
  character straddling a chunk boundary. For CJK text that is one replacement
  character per unlucky chunk, persisted into the message. The stream is now
  split into lines at the byte level and only complete lines are decoded.

fix(astrbot): finalize streams on cancel and error (P2-2 / F-13)
  Cancellation and every error path returned without a `MessageCompleted`
  event, leaving the row `streaming = 1` so it rendered as "generating" again
  after a restart. All exit paths now finalize with `Cancelled` or `Error` and
  keep the text received so far. Cancelling also no longer flips the connection
  to Disconnected and back, which was a visible flicker (P3-4 / F-56).

Hardening found while reviewing the above: a 64 MiB per-response ceiling
(removing the total timeout removed the only bound on a response, and
`read_timeout` cannot replace it), and a cursor-based line buffer instead of
draining from the front, which was quadratic in the chunk size.

Tests drive a real `AstrBotClient` against a hand-rolled HTTP/1.1 chunked-SSE
server on a raw `TcpListener`: byte-exact control over chunk boundaries and
dropping a socket mid-body without the terminal chunk are not expressible
through an HTTP framework, and both are needed here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-07-26 23:12:56 +08:00
..
desktop-protocol fix(astrbot): scope stream event ids and fix the transport layer 2026-07-26 23:12:56 +08:00
mock-gateway test(p00): add frontend browser rust and windows checks 2026-07-18 20:42:40 +08:00