From 1be5777183208632515bb299f5e87a30daa21b24 Mon Sep 17 00:00:00 2001 From: YokiiroBW Date: Sun, 5 Jul 2026 20:00:41 +0800 Subject: [PATCH] Normalize event stream limits defensively --- backend/services/event_stream_service.py | 10 +++++++++- tests/test_event_routes.py | 15 +++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/backend/services/event_stream_service.py b/backend/services/event_stream_service.py index 35b3bb6..5cdade6 100644 --- a/backend/services/event_stream_service.py +++ b/backend/services/event_stream_service.py @@ -21,7 +21,7 @@ class EventStreamService: def recent_events(self, *, event_type: str | None = None, limit: int = 50) -> dict[str, Any]: events = self.event_bus.history(event_type) - normalized_limit = min(max(int(limit or 50), 1), 200) + normalized_limit = _limit(limit) selected = events[-normalized_limit:] webhook_events = [_event_to_webhook(event) for event in selected] return { @@ -32,6 +32,14 @@ class EventStreamService: } +def _limit(value: Any) -> int: + try: + limit = int(value) if value is not None else 50 + except (TypeError, ValueError): + limit = 50 + return min(max(limit, 1), 200) + + def _event_to_webhook(event: Event) -> WebhookEvent: webhook_event = event_from_bus(event.event_type, event.payload) return WebhookEvent( diff --git a/tests/test_event_routes.py b/tests/test_event_routes.py index 4ded3ef..4f9bb2a 100644 --- a/tests/test_event_routes.py +++ b/tests/test_event_routes.py @@ -37,6 +37,21 @@ class EventRoutesTests(unittest.TestCase): self.assertEqual(response["data"]["count"], 1) self.assertEqual(response["data"]["events"][0]["event_type"], "workflow.updated") + def test_event_stream_limit_is_normalized(self): + for index in range(3): + self.event_bus.publish("task.completed", {"task_id": f"task_{index}"}) + + bad_limit = get_event_stream(self.ctx, {"limit": "bad"}, self.service) + zero_limit = get_event_stream(self.ctx, {"limit": 0}, self.service) + huge_limit = get_event_stream(self.ctx, {"limit": 999}, self.service) + + self.assertTrue(bad_limit["ok"]) + self.assertEqual(bad_limit["data"]["count"], 3) + self.assertTrue(zero_limit["ok"]) + self.assertEqual(zero_limit["data"]["count"], 1) + self.assertTrue(huge_limit["ok"]) + self.assertEqual(huge_limit["data"]["count"], 3) + def test_event_stream_requires_authentication(self): response = get_event_stream(RequestContext(), {}, self.service)