S93 审核一致性检查
这个提交存在于:
父节点
9902eaa676
当前提交
bef2f72544
共有 2 个文件被更改,包括 91 次插入 和 0 次删除
|
|
@ -110,6 +110,7 @@ class ReviewFlowEngine:
|
||||||
def review_node(self, node: WorkflowNode, images: list[GenerationImage]) -> dict[str, Any]:
|
def review_node(self, node: WorkflowNode, images: list[GenerationImage]) -> dict[str, Any]:
|
||||||
warnings: list[dict[str, Any]] = []
|
warnings: list[dict[str, Any]] = []
|
||||||
errors: list[dict[str, Any]] = []
|
errors: list[dict[str, Any]] = []
|
||||||
|
selected_image = next((image for image in images if image.image_id == node.selected_image_id), None)
|
||||||
if self.policy.warn_without_images and not images:
|
if self.policy.warn_without_images and not images:
|
||||||
warnings.append({"code": "NO_IMAGES", "message": "node has no generated images"})
|
warnings.append({"code": "NO_IMAGES", "message": "node has no generated images"})
|
||||||
if node.status in self.policy.require_selected_image_for_statuses and not node.selected_image_id:
|
if node.status in self.policy.require_selected_image_for_statuses and not node.selected_image_id:
|
||||||
|
|
@ -124,6 +125,25 @@ class ReviewFlowEngine:
|
||||||
image.image_id == node.selected_image_id and image.is_archived for image in images
|
image.image_id == node.selected_image_id and image.is_archived for image in images
|
||||||
):
|
):
|
||||||
errors.append({"code": "SELECTED_IMAGE_ARCHIVED", "message": "selected image is archived"})
|
errors.append({"code": "SELECTED_IMAGE_ARCHIVED", "message": "selected image is archived"})
|
||||||
|
if selected_image and node.model_route and selected_image.model_route and node.model_route != selected_image.model_route:
|
||||||
|
warnings.append(
|
||||||
|
{
|
||||||
|
"code": "MODEL_ROUTE_MISMATCH",
|
||||||
|
"message": "selected image model_route differs from node model_route",
|
||||||
|
"node_model_route": node.model_route,
|
||||||
|
"image_model_route": selected_image.model_route,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
if selected_image and node.prompt and selected_image.positive_prompt:
|
||||||
|
node_prompt = _normalize_prompt(node.prompt)
|
||||||
|
image_prompt = _normalize_prompt(selected_image.positive_prompt)
|
||||||
|
if node_prompt and image_prompt and node_prompt not in image_prompt and image_prompt not in node_prompt:
|
||||||
|
warnings.append(
|
||||||
|
{
|
||||||
|
"code": "PROMPT_MISMATCH",
|
||||||
|
"message": "selected image prompt differs from node prompt",
|
||||||
|
}
|
||||||
|
)
|
||||||
return {
|
return {
|
||||||
"target_type": "node",
|
"target_type": "node",
|
||||||
"target_id": node.node_id,
|
"target_id": node.node_id,
|
||||||
|
|
@ -133,7 +153,9 @@ class ReviewFlowEngine:
|
||||||
"summary": {
|
"summary": {
|
||||||
"image_count": len(images),
|
"image_count": len(images),
|
||||||
"selected_image_id": node.selected_image_id,
|
"selected_image_id": node.selected_image_id,
|
||||||
|
"selected_image_model_route": selected_image.model_route if selected_image else None,
|
||||||
"node_status": node.status,
|
"node_status": node.status,
|
||||||
|
"node_model_route": node.model_route,
|
||||||
"policy_version": self.policy.version,
|
"policy_version": self.policy.version,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
@ -155,6 +177,21 @@ class ReviewFlowEngine:
|
||||||
"node_ids": incomplete,
|
"node_ids": incomplete,
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
|
selected_model_routes = sorted(
|
||||||
|
{
|
||||||
|
str(result["summary"].get("selected_image_model_route"))
|
||||||
|
for result in node_results
|
||||||
|
if result["summary"].get("selected_image_model_route")
|
||||||
|
}
|
||||||
|
)
|
||||||
|
if len(selected_model_routes) > 1:
|
||||||
|
warnings.append(
|
||||||
|
{
|
||||||
|
"code": "INCONSISTENT_SELECTED_MODEL_ROUTES",
|
||||||
|
"message": "workflow selected images use multiple model routes",
|
||||||
|
"model_routes": selected_model_routes,
|
||||||
|
}
|
||||||
|
)
|
||||||
return {
|
return {
|
||||||
"target_type": "workflow",
|
"target_type": "workflow",
|
||||||
"target_id": workflow.workflow_id,
|
"target_id": workflow.workflow_id,
|
||||||
|
|
@ -165,6 +202,7 @@ class ReviewFlowEngine:
|
||||||
"workflow_type": workflow.workflow_type,
|
"workflow_type": workflow.workflow_type,
|
||||||
"node_count": len(nodes),
|
"node_count": len(nodes),
|
||||||
"incomplete_count": len(incomplete),
|
"incomplete_count": len(incomplete),
|
||||||
|
"selected_model_routes": selected_model_routes,
|
||||||
"policy_version": self.policy.version,
|
"policy_version": self.policy.version,
|
||||||
},
|
},
|
||||||
"nodes": node_results,
|
"nodes": node_results,
|
||||||
|
|
@ -185,3 +223,7 @@ def _normalize_status_list(value: Any) -> tuple[str, ...]:
|
||||||
if status and status not in statuses:
|
if status and status not in statuses:
|
||||||
statuses.append(status)
|
statuses.append(status)
|
||||||
return tuple(statuses)
|
return tuple(statuses)
|
||||||
|
|
||||||
|
|
||||||
|
def _normalize_prompt(value: str) -> str:
|
||||||
|
return " ".join(str(value or "").lower().replace(",", " ").split())
|
||||||
|
|
|
||||||
|
|
@ -100,6 +100,55 @@ class ReviewServiceTests(unittest.TestCase):
|
||||||
self.assertTrue(result["passed"])
|
self.assertTrue(result["passed"])
|
||||||
self.assertEqual(result["summary"]["selected_image_id"], image.image_id)
|
self.assertEqual(result["summary"]["selected_image_id"], image.image_id)
|
||||||
|
|
||||||
|
def test_review_warns_about_prompt_and_model_route_mismatch(self):
|
||||||
|
node = self.workflow.nodes[1]
|
||||||
|
self.workflow_service.update_node(
|
||||||
|
node.node_id,
|
||||||
|
{"status": "completed", "prompt": "portrait, silver hair", "model_route": "image_high"},
|
||||||
|
self.ctx,
|
||||||
|
)
|
||||||
|
image = self.image_service.create_image(
|
||||||
|
{
|
||||||
|
"node_id": node.node_id,
|
||||||
|
"image_uri": "storage://images/mismatch.png",
|
||||||
|
"positive_prompt": "landscape, blue sky",
|
||||||
|
"model_route": "image_low",
|
||||||
|
"is_selected": True,
|
||||||
|
},
|
||||||
|
self.ctx,
|
||||||
|
)
|
||||||
|
|
||||||
|
result = self.review_service.review_node(node.node_id)
|
||||||
|
|
||||||
|
self.assertTrue(result["passed"])
|
||||||
|
self.assertEqual(result["summary"]["selected_image_id"], image.image_id)
|
||||||
|
self.assertIn("MODEL_ROUTE_MISMATCH", [warning["code"] for warning in result["warnings"]])
|
||||||
|
self.assertIn("PROMPT_MISMATCH", [warning["code"] for warning in result["warnings"]])
|
||||||
|
|
||||||
|
def test_review_workflow_warns_when_selected_images_mix_model_routes(self):
|
||||||
|
first, second = self.workflow.nodes[:2]
|
||||||
|
for node, route in ((first, "image_low"), (second, "image_high")):
|
||||||
|
self.workflow_service.update_node(
|
||||||
|
node.node_id,
|
||||||
|
{"status": "completed", "prompt": f"{route} prompt", "model_route": route},
|
||||||
|
self.ctx,
|
||||||
|
)
|
||||||
|
self.image_service.create_image(
|
||||||
|
{
|
||||||
|
"node_id": node.node_id,
|
||||||
|
"image_uri": f"storage://images/{route}.png",
|
||||||
|
"positive_prompt": f"{route} prompt",
|
||||||
|
"model_route": route,
|
||||||
|
"is_selected": True,
|
||||||
|
},
|
||||||
|
self.ctx,
|
||||||
|
)
|
||||||
|
|
||||||
|
result = self.review_service.review_workflow(self.workflow.workflow.workflow_id)
|
||||||
|
|
||||||
|
self.assertIn("INCONSISTENT_SELECTED_MODEL_ROUTES", [warning["code"] for warning in result["warnings"]])
|
||||||
|
self.assertEqual(result["summary"]["selected_model_routes"], ["image_high", "image_low"])
|
||||||
|
|
||||||
def test_review_routes_require_authentication(self):
|
def test_review_routes_require_authentication(self):
|
||||||
node = self.workflow.nodes[0]
|
node = self.workflow.nodes[0]
|
||||||
response = review_node(self.ctx, node.node_id, self.review_service)
|
response = review_node(self.ctx, node.node_id, self.review_service)
|
||||||
|
|
|
||||||
正在加载…
添加表格
在新工单中引用