from __future__ import annotations import pytest from adapters.astrbot_adapter import dispatch_extension_request, resolve_route from backend.route_registry import ROUTES, PERMISSION_MATRIX from core.identity import RequestContext from core.security import enforce_route_permission from backend.dto.common import ApiError, ErrorCode def _ctx(permissions: frozenset[str] | None = None, *, authenticated: bool = True) -> RequestContext: if not authenticated: return RequestContext.from_astrbot( username=None, user_id=None, client_ip="127.0.0.1", source="test", permissions=frozenset() ) return RequestContext.from_astrbot( username="tester", user_id="tester", client_ip="127.0.0.1", source="test", permissions=permissions if permissions is not None else frozenset(), ) def test_anonymous_request_is_rejected_before_the_handler_runs() -> None: """Regression: the dispatcher used to ignore RouteMatch.permission entirely.""" response = dispatch_extension_request(_ctx(authenticated=False), "GET", "profiles") assert response["ok"] is False assert response["error_code"] == ErrorCode.UNAUTHORIZED def test_read_permission_is_not_enough_for_a_config_route() -> None: """A logged-in user without can_manage_config must not reach settings/save.""" response = dispatch_extension_request(_ctx(frozenset()), "POST", "settings/save", payload={}) assert response["ok"] is False assert response["error_code"] == ErrorCode.FORBIDDEN def test_retry_permission_requires_both_declared_capabilities() -> None: """The 'retry' tier declares required_permissions=[can_write, can_retry_tasks].""" with pytest.raises(ApiError) as excinfo: enforce_route_permission(_ctx(frozenset({"can_retry_tasks"})), "retry") assert excinfo.value.error_code == ErrorCode.FORBIDDEN assert excinfo.value.details["permission"] == "can_write" # Both present -> passes. enforce_route_permission(_ctx(frozenset({"can_write", "can_retry_tasks"})), "retry") def test_public_token_tier_does_not_demand_authentication() -> None: """media/fetch is served to a signed URL, so it must stay reachable.""" enforce_route_permission(_ctx(authenticated=False), "public_token") @pytest.mark.parametrize("permission", sorted(PERMISSION_MATRIX)) def test_every_declared_permission_tier_is_enforceable(permission: str) -> None: """Every tier in the matrix must be something the dispatcher can apply.""" ctx = _ctx(frozenset({"can_write", "can_manage_config", "can_manage_materials", "can_retry_tasks"})) enforce_route_permission(ctx, permission) def test_all_routes_declare_a_known_permission() -> None: unknown = sorted({r.permission for r in ROUTES if r.permission not in PERMISSION_MATRIX}) assert unknown == [] def test_resolve_route_still_reports_the_declared_permission() -> None: match = resolve_route("POST", "settings/save") assert match is not None assert match.permission == "config"