from __future__ import annotations import tempfile import unittest from pathlib import Path from backend.routes.review_routes import get_review_policy, review_node, review_workflow, validate_review_policy from backend.services.history_service import HistoryService from backend.services.image_service import ImageService from backend.services.profile_service import ProfileService from backend.services.review_service import ReviewService from backend.services.workflow_service import WorkflowService from core.audit_service import AuditService from core.identity import RequestContext from database.db_helper import Database, DatabaseSettings, SqliteSettings from database.repositories.image_repository import ImageRepository from database.repositories.profile_repository import ProfileRepository from database.repositories.workflow_repository import WorkflowRepository class ReviewServiceTests(unittest.TestCase): def setUp(self): self.tmp = tempfile.TemporaryDirectory() self.database = Database( DatabaseSettings(sqlite=SqliteSettings(path=str(Path(self.tmp.name) / "imagestudio.db"))) ) self.database.initialize() self.audit_service = AuditService(self.database) self.profile_repository = ProfileRepository(self.database) self.workflow_repository = WorkflowRepository(self.database) self.image_repository = ImageRepository(self.database) self.profile_service = ProfileService(self.profile_repository, self.audit_service) self.workflow_service = WorkflowService( self.workflow_repository, self.profile_repository, self.audit_service, ) self.image_service = ImageService( self.image_repository, self.workflow_repository, self.audit_service, ) self.history_service = HistoryService( self.workflow_repository, self.workflow_service, self.image_service, self.audit_service, ) self.review_service = ReviewService(self.workflow_service, self.image_repository) self.ctx = RequestContext.from_astrbot( username="admin", user_id="user_001", permissions={"can_write", "can_manage_config"}, ) self.profile = self.profile_service.create_profile({"name": "Nova"}, self.ctx) self.workflow = self.workflow_service.create_workflow( self.profile.profile_id, {"workflow_type": "character_fast", "display_name": "Fast"}, self.ctx, ) def tearDown(self): self.tmp.cleanup() def test_review_node_warns_without_images_and_errors_without_selected_image(self): node = self.workflow.nodes[0] empty = self.review_service.review_node(node.node_id) self.assertTrue(empty["passed"]) self.assertEqual(empty["warnings"][0]["code"], "NO_IMAGES") self.workflow_service.update_node(node.node_id, {"status": "completed"}, self.ctx) missing_selection = self.review_service.review_node(node.node_id) self.assertFalse(missing_selection["passed"]) self.assertEqual(missing_selection["errors"][0]["code"], "MISSING_SELECTED_IMAGE") def test_review_passes_after_image_adoption(self): node = self.workflow.nodes[1] image = self.image_service.create_image( { "node_id": node.node_id, "image_uri": "storage://images/fast.png", "positive_prompt": "fast character", }, self.ctx, ) self.history_service.adopt_node_image(node.node_id, {"image_id": image.image_id}, self.ctx) result = self.review_service.review_node(node.node_id) self.assertTrue(result["passed"]) self.assertEqual(result["summary"]["selected_image_id"], image.image_id) def test_review_routes_require_authentication(self): node = self.workflow.nodes[0] response = review_node(self.ctx, node.node_id, self.review_service) self.assertTrue(response["ok"]) workflow_response = review_workflow(self.ctx, self.workflow.workflow.workflow_id, self.review_service) self.assertTrue(workflow_response["ok"]) self.assertEqual(workflow_response["data"]["summary"]["node_count"], 3) anonymous = RequestContext() denied = review_node(anonymous, node.node_id, self.review_service) self.assertFalse(denied["ok"]) self.assertEqual(denied["error_code"], "UNAUTHORIZED") def test_review_policy_is_exposed_and_validated(self): policy_response = get_review_policy(self.ctx, self.review_service) self.assertTrue(policy_response["ok"]) self.assertEqual(policy_response["data"]["version"], "default-v1") self.assertIn("completed", policy_response["data"]["require_selected_image_for_statuses"]) valid_response = validate_review_policy( self.ctx, { "version": "custom-v1", "warn_without_images": False, "require_selected_image_for_statuses": ["selected"], "workflow_terminal_statuses": ["selected", "skipped"], }, self.review_service, ) self.assertTrue(valid_response["ok"]) self.assertTrue(valid_response["data"]["valid"]) self.assertFalse(valid_response["data"]["policy"]["warn_without_images"]) self.assertEqual(valid_response["data"]["policy"]["version"], "custom-v1") invalid_response = validate_review_policy( self.ctx, { "warn_without_images": "yes", "workflow_terminal_statuses": ["selected", "unknown"], }, self.review_service, ) self.assertTrue(invalid_response["ok"]) self.assertFalse(invalid_response["data"]["valid"]) self.assertEqual( [error["code"] for error in invalid_response["data"]["errors"]], ["INVALID_BOOLEAN", "UNKNOWN_STATUS"], ) def test_review_policy_validation_requires_config_permission(self): read_only = RequestContext.from_astrbot(username="reader", user_id="user_002", permissions=set()) response = validate_review_policy(read_only, {}, self.review_service) self.assertFalse(response["ok"]) self.assertEqual(response["error_code"], "FORBIDDEN") if __name__ == "__main__": unittest.main()