The readiness fix had unit coverage for _chat_provider_ready and the fallback
upgrade helpers, but nothing asserting the thing that actually went wrong in
production: that a not-ready round leaves the day untouched. "It returned
None" and "it wrote a fallback and pinned the whole day" are both plausible
readings of a green pure-function test.
Three cases through _ensure_daily_plan itself: not ready writes no plan and
counts one wait; the round after the configured limit is the first one allowed
to degrade, and it must actually produce a plan; a ready provider generates
immediately and clears the wait counter, so a later genuine outage gets its
full budget.
Companion suite 246 passed, joint E2E 146/146.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
All three shared a shape: the symptom was invisible from the data, so every
acceptance run stayed green while the VM was failing.
daily_state still called _ensure_daily_news_reading, removed when the news
feature was retired. The VM threw AttributeError 14 times in three hours and
marked the "today's schedule" maintenance step failed, but the crash sits
after the plan is saved -- so the stored plan always looked correct. Removed
the call and added a repo-wide scan rather than a single-point assertion,
since this kind of residue is by definition somewhere you did not look.
enable_memory_companion_bridge, the master switch for the whole archive
chain, was never added to _conf_schema.json. _cfg_bool falls back to True, so
the feature worked and only its operability was missing -- nothing could have
failed. It now sits in the visible external_memory_config group, with an
assertion that _flat_get still resolves it by flat key.
A fallback plan carried today's date, and all three reuse branches key on the
date alone, so one startup timing hiccup froze a template plan into the day
and archived it as real. source="fallback" was produced and never consumed;
now a fallback can be upgraded once the provider is back, capped at three
attempts and bucketed per day.
Also fixed two test files whose classes sat after the __main__ guard (silently
dropped when run directly) and the retired-config prefix list, which only
listed the uppercase WEB_EXPLORATION_ form and missed the lowercase schema keys.
VM after restart: 0 AttributeError, 0 ERRO/Traceback, plan intact at v2/llm,
switch materialised as True. Companion suite 218 passed, joint E2E 135/135.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>